Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pda space #32601

Merged
merged 8 commits into from
Oct 31, 2024
Merged

More pda space #32601

merged 8 commits into from
Oct 31, 2024

Conversation

BramvanZijp
Copy link
Contributor

@BramvanZijp BramvanZijp commented Oct 2, 2024

About the PR

The following changes were made in this PR:
The max programs a PDA can have was set to 8.
The Brigmedic PDA now comes with the wanted list program. (No CL since it is not in use.)
The HoS and Detective PDA now come with the logprobe program.
ERT, CC, Admin and Deathsquad PDAs now all come with more programs (wanted list, logprobe, medtek, astronav) and a maximum capacity of 16 programs./

Why / Balance

With more and more PDA programs being added as functionality is moved from PDAs to these programs, some PDAs were only able to install one more program or even no extra programs. This PR increases this number to compensate.
In regards to the logprobe, this is essential equipment for the detective, and I believe they and their boss (the HoS) should be given it roundstart just like how doctors or salvagers are given their programs roundstart.
As for the admeme pdas, these are all high-ranking positions that should realistically have access to all of these programs.

Media

Not much to show.

Requirements

Changelog
🆑 BramvanZijp

  • tweak: The maximum amount of programs that can be installed on a PDA has been increased from 5 to 8
  • tweak: The Detective and Head of Security now get the logprobe program pre-installed on their PDA.
    ADMIN:
  • tweak: CC, ERT, Admin, and Deathsquad PDA's now have all departmental programs pre-installed.

@lzk228
Copy link
Contributor

lzk228 commented Oct 2, 2024

imo pda programs interface should be reworked to be able to contain more programs on one screen

@BramvanZijp
Copy link
Contributor Author

imo pda programs interface should be reworked to be able to contain more programs on one screen

A scrollbar is added if too many are on there

@IProduceWidgets
Copy link
Contributor

I think there should only be room for 1 more instal by deafult pdas

@Everturning
Copy link

whos in support of just making PDAs tablets like in 13 with downloading things that you have access to and the limits being limited space for downloads

@YotaXP
Copy link

YotaXP commented Oct 3, 2024

Surely software capacity will need to be upgradeable (by the HoP) so that promoted crewmembers will be able to install all their needed software.

@BramvanZijp
Copy link
Contributor Author

Surely software capacity will need to be upgradeable (by the HoP) so that promoted crewmembers will be able to install all their needed software.

3 extra programs should be enough for that, though itd be nice if HoP could create specific PDAs.

@Everturning
Copy link

guys you're describing the PDA/tablet painter and tablet PDAs

@BramvanZijp
Copy link
Contributor Author

guys you're describing the PDA/tablet painter and tablet PDAs

Yea but like untill that gets added this would be nice

@chromiumboy chromiumboy added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Oct 26, 2024
@chromiumboy chromiumboy self-assigned this Oct 26, 2024
Copy link
Contributor

@chromiumboy chromiumboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maintainers discussed the PR and we have the following requested changes:

  • PDAs should ideally have the same number of slots available (8?), for consistency sake. Some will just have more free slots than others, depending on the number of pre-installed programs
  • The security and medical related programs need to be removed from the captain's PDA
  • The GPS cartridge should only be preinstalled on the salvage PDA (for regular crew at least)
  • The programs on the ERT and Centcomm PDAs are fine

@chromiumboy chromiumboy added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. labels Oct 29, 2024
@BramvanZijp
Copy link
Contributor Author

Changes applied.

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 29, 2024
@chromiumboy
Copy link
Contributor

OK, looks good :)

@chromiumboy chromiumboy added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Oct 31, 2024
@slarticodefast slarticodefast merged commit a08da9d into space-wizards:master Oct 31, 2024
12 of 13 checks passed
iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
* Rebalance the max programs that a PDA can hold

* Give Caps PDA more programs too.

* Make the max programs a static 8

* I forgor sec and med

* CaseCase

* Empty commit to re-run checks

* The final change, I hope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants